Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance updates #193

Merged
merged 15 commits into from
Aug 7, 2023
Merged

Maintenance updates #193

merged 15 commits into from
Aug 7, 2023

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

This isn't as big as it looks, though there's possibly a lotta changes.

I'll self-review and try to guide you through it to ease the task.

Whenever a change is not super-explicit or supported by the commit message I'll add a comment.

Only keep generated stuff + _* (e.g. for _build and _checkouts)
- erl_opts heavily trimmed
- ct_compile_opts removed
- ct_opts updated and moved into profile `test`
- ct_extra_params moved into profile `test`
- cover_enabled moved into profile `test`
- cover_export_enabled moved into profile `test`
- cover_opts moved into profile `test`
- edoc_opts removed
- dialyzer race_conditions removed (no longer supported)
- project_plugins' versions updated or added
- alias test now runs `xref` and `ex_doc` (instead of `edoc`)
- ex_doc added
- Dialyzer and XRef moved to their "own" section
Version 0.2.19 is failing with an issue I can't understand at the
moment
In OTP 25, reply_tag/0 and request_id/0 were exposed
  in erlang/otp#5751, as opaque.

gen_server's
  Type   request_id() :: term()
became
  Opaque request_id() :: gen:request_id()

gen_server's
  Type from() :: {pid(), Tag :: term()}
became
  Type {Client :: pid(), Tag :: reply_tag()}
where reply_tag() is opaque

thus "breaking" the type, and supporting the need for this change.
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (d117503) 92.39% compared to head (b1980cc) 92.34%.

❗ Current head b1980cc differs from pull request most recent head 327b58a. Consider uploading reports for the commit 327b58a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   92.39%   92.34%   -0.06%     
==========================================
  Files          10       10              
  Lines         447      444       -3     
==========================================
- Hits          413      410       -3     
  Misses         34       34              
Files Changed Coverage Δ
src/wpool.erl 97.22% <ø> (ø)
src/wpool_process.erl 80.51% <ø> (-0.25%) ⬇️
src/wpool_process_callbacks.erl 89.47% <ø> (ø)
src/wpool_queue_manager.erl 87.35% <ø> (-0.15%) ⬇️
src/wpool_sup.erl 100.00% <ø> (ø)
src/wpool_time_checker.erl 100.00% <ø> (ø)
src/wpool_utils.erl 100.00% <ø> (ø)
src/wpool_worker.erl 100.00% <ø> (ø)
src/wpool_pool.erl 96.52% <100.00%> (ø)
src/wpool_process_sup.erl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

This is happening, too
image

src/wpool.erl Outdated Show resolved Hide resolved
src/wpool_pool.erl Outdated Show resolved Hide resolved
src/wpool_process_sup.erl Outdated Show resolved Hide resolved
src/wpool_process_sup.erl Show resolved Hide resolved
src/wpool_queue_manager.erl Show resolved Hide resolved
src/wpool_utils.erl Show resolved Hide resolved
@paulo-ferraz-oliveira
Copy link
Collaborator Author

I guess this is now warranting a change
image

😄

@elbrujohalcon elbrujohalcon mentioned this pull request Aug 7, 2023
@elbrujohalcon
Copy link
Member

Let's go with "remove 24 from CI".

@elbrujohalcon elbrujohalcon merged commit 366a937 into inaka:main Aug 7, 2023
2 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/minor-maintenance-updates branch August 7, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants