-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance updates #193
Merged
elbrujohalcon
merged 15 commits into
inaka:main
from
paulo-ferraz-oliveira:feature/minor-maintenance-updates
Aug 7, 2023
Merged
Maintenance updates #193
elbrujohalcon
merged 15 commits into
inaka:main
from
paulo-ferraz-oliveira:feature/minor-maintenance-updates
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only keep generated stuff + _* (e.g. for _build and _checkouts)
- erl_opts heavily trimmed - ct_compile_opts removed - ct_opts updated and moved into profile `test` - ct_extra_params moved into profile `test` - cover_enabled moved into profile `test` - cover_export_enabled moved into profile `test` - cover_opts moved into profile `test` - edoc_opts removed - dialyzer race_conditions removed (no longer supported) - project_plugins' versions updated or added - alias test now runs `xref` and `ex_doc` (instead of `edoc`) - ex_doc added - Dialyzer and XRef moved to their "own" section
Version 0.2.19 is failing with an issue I can't understand at the moment
In OTP 25, reply_tag/0 and request_id/0 were exposed in erlang/otp#5751, as opaque. gen_server's Type request_id() :: term() became Opaque request_id() :: gen:request_id() gen_server's Type from() :: {pid(), Tag :: term()} became Type {Client :: pid(), Tag :: reply_tag()} where reply_tag() is opaque thus "breaking" the type, and supporting the need for this change.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 92.39% 92.34% -0.06%
==========================================
Files 10 10
Lines 447 444 -3
==========================================
- Hits 413 410 -3
Misses 34 34
☔ View full report in Codecov by Sentry. |
elbrujohalcon
requested changes
Aug 7, 2023
rebar.config tells a different story, as per the README, but that's intentional
Closed
elbrujohalcon
approved these changes
Aug 7, 2023
Let's go with "remove 24 from CI". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't as big as it looks, though there's possibly a lotta changes.
I'll self-review and try to guide you through it to ease the task.
Whenever a change is not super-explicit or supported by the commit message I'll add a comment.